Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #949

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve CI #949

wants to merge 2 commits into from

Conversation

akkashk
Copy link

@akkashk akkashk commented Jan 28, 2022

  • Remove Travis CI
  • Tidy up circle CI file
  • Add support for black formatting

@akkashk akkashk marked this pull request as ready for review February 3, 2022 17:23
@akkashk
Copy link
Author

akkashk commented Feb 3, 2022

@dunckerr PR is ready for review, I've split the changes into self-contained commits since I'm reformatting a lot of files as part of black changes

@akkashk akkashk requested a review from dunckerr February 3, 2022 17:24
@bmoscon
Copy link
Collaborator

bmoscon commented Feb 3, 2022

I thought in the past someone tried a massive reformatting of everything similar to this (maybe it was using black, maybe not, was years ago) and we opted to not accept it because it made a lot of changes that polluted the change history/blame for little gain. What is the reason behind this change? @jamesblackburn I believe you were involved in the past ticket/PR to which I am referring.

@dunckerr
Copy link
Contributor

dunckerr commented Feb 3, 2022

@akkashk I agree with Bryant - can we add the black code to .circleci but comment it out for now? if we're going to do the black reformat we should do it with 1 commit and when everyone is happy.

Second question - does $VERSION get passed into the the individual build sections at the bottom of the file? I thought you said that was broken and I cant see how you fixed it?

@bmoscon
Copy link
Collaborator

bmoscon commented Feb 3, 2022

I'm not opposed to circle, but why not use github actions? They seem much more powerful and flexible than anything I've seen on Travis or Circle

@akkashk
Copy link
Author

akkashk commented Feb 3, 2022

Happy to remove my commit with black changes.

does $VERSION get passed into the the individual build sections at the bottom of the file

@dunckerr before we were setting the env var $VERSION in a separate step and writing it to the file in a different step. Now it's all done as part of the same step which should fix the issue

@akkashk
Copy link
Author

akkashk commented Feb 3, 2022

I'm not opposed to circle, but why not use github actions?

Don't have a strong preference. Our other open source projects use circleci and it's nice being able to share some CI config code between them.

@akkashk akkashk self-assigned this Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants